Keyword
Please note that official support for commercial extensions & templates is provided in the Subscriber Help Desk.
Support requests should ONLY be directed there and require an active subscription plan.
This forum board is to be used for archive purposes and knowledge exchange ONLY.

Performance issue

  • JoomlaWorks Support Team
  • JoomlaWorks Support Team's Avatar Topic Author
  • Offline
  • Platinum Member
More
16 years 5 months ago - 15 years 4 weeks ago #9359 by JoomlaWorks Support Team
Performance issue was created by JoomlaWorks Support Team
Hi my friends!

Cause a minor bug at the php code of the SIG Pro mambot
the thumbs of the gallery are creating every time it loads the page!

Please, open to edit the file mambots/content/plugin_jw_sigpro.php
and at the line 289 where you can find the code
// create thumbnails
if (file_exists($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).$format) && filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).$format) + $cache_expire_time * 60 > time()) {
  $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$tempfolder.md5($_images_dir_.$name).$format.'" />'.$rightcomment;
}
replace it with this code
// create thumbnails
if (file_exists($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) && filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) + $cache_expire_time * 60 > time()) {
  $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$mosConfig_live_site.$tempfolder.md5($_images_dir_.$name).".".$format.'" />'.$rightcomment;
}

Thank you!

JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
The topic has been locked.
More
16 years 4 months ago #9360 by Andy Wilson
Replied by Andy Wilson on topic Re: Performance issue
Is it possible to download SIG Pro again - with the modified code please?

Thanks,

Andy Wilson
The topic has been locked.
More
16 years 4 months ago #9361 by Lefteris
Replied by Lefteris on topic Re: Performance issue

Cause a minor bug at the php code of the SIG Pro mambot
the thumbs of the gallery are creating every time it loads the page!


Well (seven months later) that probably explains this...

Its cache mechanism is a menace, should carry a Government Health Warning and, preferably an OptOutCompletely command line switch. It's awful. It doesn't 'work'... Well, not as far as I've managed to observe;~| I also believe it is actually counter-productive but haven't been able to fully determine this because of all the other issues/problems with SIG PRO [sic] v1.2.


----best wishes, Robert

JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
The topic has been locked.
More
16 years 4 months ago #9362 by Lefteris
Replied by Lefteris on topic Re: Performance issue
!? now causes 'undefined index' PHP errors on the two occasions on the
'if' line right after each of the two '// if labels do exist' areas!?
Do you need to extend your work/fix now to those two lines as well?

----best wishes, Robert

// create thumbnails
				if (file_exists($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) && filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) + $cache_expire_time * 60 > time()) {
				 $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$mosConfig_live_site.$tempfolder.md5($_images_dir_.$n

and
// if labels do exist
				if ($labels[md5($mosConfig_absolute_path.$rootfolder.$_images_dir_.'/'.$images[$a])]!="") {

JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
The topic has been locked.
More
16 years 4 months ago #9363 by Lefteris
Replied by Lefteris on topic Re: Performance issue
On the topic of 'performance issue' and 'cache'...
at what point does SIG Pro purge its thumbnail cache?
ie after (say) 120minutes of expiration time set in options.
What and where is the mechanism that does the purge
ie performs the housekeeping removal of stale files.

----best wishes, Robert

JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
The topic has been locked.
  • José Luis Ayala M.
  • José Luis Ayala M.'s Avatar
  • Offline
  • New Member
More
16 years 4 months ago #9364 by José Luis Ayala M.
Replied by José Luis Ayala M. on topic Re: Performance issue

Hi my friends!

Cause a minor bug at the php code of the SIG Pro mambot
the thumbs of the gallery are creating every time it loads the page!

Please, open to edit the file mambots/content/plugin_jw_sigpro.php
and at the line 289 where you can find the code

// create thumbnails
if (file_exists($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).$format) && filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).$format) + $cache_expire_time * 60 > time()) {
  $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$tempfolder.md5($_images_dir_.$name).$format.'" />'.$rightcomment;
}
replace it with this code
// create thumbnails
if (file_exists($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) && filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) + $cache_expire_time * 60 > time()) {
  $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$mosConfig_live_site.$tempfolder.md5($_images_dir_.$name).".".$format.'" />'.$rightcomment;
}

Thank you!



Hi vinikey,

I made those changes in my site, to change the original thumbails for another ones (custom thumbails), but from time to time, it goes again to the originals. 
 
Is there a way to keep my custom thumbails?. 
 
Regards 
Jos
The topic has been locked.
  • JoomlaWorks Support Team
  • JoomlaWorks Support Team's Avatar Topic Author
  • Offline
  • Platinum Member
More
16 years 4 months ago #9365 by JoomlaWorks Support Team
Replied by JoomlaWorks Support Team on topic Re: Performance issue
Hi my friend!

Can you remember me what change you have done to use custom thumbs?!

Try to remove the code expression
&& filemtime ($mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format) + $cache_expire_time * 60 > time()
In this way will not be used the cache control.

Thank you!

JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)
The topic has been locked.
  • José Luis Ayala M.
  • José Luis Ayala M.'s Avatar
  • Offline
  • New Member
More
16 years 4 months ago #9366 by José Luis Ayala M.
Replied by José Luis Ayala M. on topic Re: Performance issue
Thanks for your answer vinikey,

I only made the changes that I mention in my post "...open to edit the file mambots/content/plugin_jw_sigpro.php and at the line 289 where you can find the code... bla, bla...". 
 
I will try your suggestion.

Regards
Jos
The topic has been locked.

Powered by Kunena Forum