COMMUNITY FORUM

Admin Item Form Styling Issue

Start
Prev
1
Next
End

Paul Adamson
Topic Author
Offline
Junior Member

9 years 3 months ago #150692 by Paul Adamson

Admin Item Form Styling Issue was created by Paul Adamson

Hi, I'm using Joomla 3.4.8 and the latest K2 dev build from github. When I load the new item form, the styling on the extra fields tab is not correct. Some of the functionality is strange also, such as when a radio button is clicked it does not change appearance, which I suppose is still just a visual behaviour. See uploaded screenshot at http://imgur.com/9Pow51L . I don't have any javascript errors in the console so I don't think there's a conflict with anything.

If I save the item, then check the fields, the tab styling displays correctly.

Is there anything I might do to correct this?

Thanks for your help,
Paul

Please Log in or Create an account to join the conversation.

Krikor Boghossian
Offline
Platinum Member

9 years 3 months ago #150699 by Krikor Boghossian

Replied by Krikor Boghossian on topic Admin Item Form Styling Issue

Hello,

When did you download the package? Can you try with a fresh new copy?

Please Log in or Create an account to join the conversation.

Paul Adamson
Topic Author
Offline
Junior Member

9 years 3 months ago #150729 by Paul Adamson

Replied by Paul Adamson on topic Admin Item Form Styling Issue

I just downloaded the latest today and see the same behaviour. I took a diff of the view-source of the page with an empty new form and a form saved with just a title, in both cases a category is selected so the extra fields display. The results don't indicate anything remarkable to me. I've listed the two files:

pastebin.com/xbkHuf42

pastebin.com/Mhcp02fu

Does this shed any light?

Cheers
Paul

Please Log in or Create an account to join the conversation.

Krikor Boghossian
Offline
Platinum Member

9 years 3 months ago #150736 by Krikor Boghossian

Replied by Krikor Boghossian on topic Admin Item Form Styling Issue

Try clearing your browser's cache. You were using an outdated version indeed.
The styling I am seeing is different.

Please Log in or Create an account to join the conversation.

Paul Adamson
Topic Author
Offline
Junior Member

9 years 3 months ago - 9 years 3 months ago #150811 by Paul Adamson

Replied by Paul Adamson on topic Admin Item Form Styling Issue

Hi Krikor, I've learned a bit about this the last few days. It seems to be related to a commit made about 8 days ago.

There are two issues with this commit. I'll deal with the original one in this post.

Problem: K2 Module Edit form not styled. This also affects the extra fields styling in the item edit form, and its resolved the same way:

These lines in k2.modules.css causes the k2 buttons and related styling to be applied incorrectly:

.com_modules .form-horizontal .controls:not(#jform_menuselect) label, 
.com_modules .controls:not(#jform_menuselect) label,
.com_menus .controls label, .com_config .controls label { min-width:85px;width:auto; text-align:center; border:1px solid #d4d6d8;line-height:33px;vertical-align:top;height:33px;font-size:12px;margin:0 -2px;padding:0 13px;

color:#8a8c8c;display:inline-block;vertical-align:middle;white-space:nowrap;background-color:#eff1f1;
box-shadow:0 1px 1px rgba(65,64,66,.14), inset 0 1px 0 #fff; }

The styling code used to look like this:

.com_modules .form-horizontal .controls:not(#jform_menuselect) label, 
.com_modules .controls:not(#jform_menuselect) label,
.com_menus .controls label { min-width:85px;width:auto; text-align:center; border:1px solid #d4d6d8;line-height:33px;vertical-align:top;height:33px;font-size:12px;margin:0 -2px;padding:0 13px;

color:#8a8c8c;display:inline-block;vertical-align:middle;white-space:nowrap;background-color:#eff1f1;		  color:#8a8c8c;display:inline-block;vertical-align:middle;white-space:nowrap;background-color:#eff1f1;
box-shadow:0 1px 1px rgba(65,64,66,.14), inset 0 1px 0 #fff; }

You can see from the screenshot of the old code in the style pane here:

k2-content-old-styling.png imgur.com/FNYyRFg

and the screenshot of the new code in the style pane here:

k2-content-new-styling.png imgur.com/kIFdtUw

Does that make sense?

Cheers
Paul

Last edit: 9 years 3 months ago by Paul Adamson. Reason: code style

Please Log in or Create an account to join the conversation.

Krikor Boghossian
Offline
Platinum Member

9 years 3 months ago #150818 by Krikor Boghossian

Replied by Krikor Boghossian on topic Admin Item Form Styling Issue

This code will not be executed in the itemform, furthermore the classes you removed - .com_config .controls label - are only for the configuration view (parameters).

The other ones are for the module and menu views.

Please Log in or Create an account to join the conversation.

Start
Prev
1
Next
End