Keyword
Please note that official support for commercial extensions & templates is provided in the Subscriber Help Desk.
Support requests should ONLY be directed there and require an active subscription plan.
This forum board is to be used for archive purposes and knowledge exchange ONLY.

Cache bug?

  • Maxim Milakov
  • Maxim Milakov's Avatar Topic Author
  • Offline
  • New Member
More
17 years 1 week ago - 17 years 1 week ago #2275 by Maxim Milakov
Cache bug? was created by Maxim Milakov
I have just installed PRO version (v 1.2) and noticed that the time it takes to load the page with SIG significantly increased (in comparison with Free version). Ok, I thought that it just the 1st time - the plugin generates previews and saves them to disk. But the performance didn't improve - all subsequent page loads took the same large (about 5 seconds) time.

I checked the code and found the bug, which caused checks for thumbnail existence to always fail.

File plugin_jw_sigpro.php: the code should be:
				// create thumbnails
			        $toname = $mosConfig_absolute_path.$tempfolder.md5($_images_dir_.$name).".".$format;
			        $toname_live = $mosConfig_live_site.$tempfolder.md5($_images_dir_.$name).".".$format;
				if (file_exists($toname) && (filemtime ($toname) + $cache_expire_time * 60 > time())) {
				 $html .= $leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$toname_live.'" />'.$rightcomment;
				} else {
				 $fromname = $mosConfig_absolute_path.$rootfolder.$_images_dir_.'/'.$images[$a];
				 $result = makeThumb( $fromname, $toname, $image_type, $_quality_, $_width_final_, $_height_final_);
				 if($result)
				    $html .=$leftcomment.'<img alt="'.$clickopen.'" title="'.$clickopen.'" src="'.$toname_live.'" />'.$rightcomment;
				 else
				    $html .='<span>Error creating thumbnail!</span>';
				}

Please Log in or Create an account to join the conversation.

More
17 years 1 week ago - 17 years 1 week ago #2276 by JoomlaWorks
Replied by JoomlaWorks on topic Re: Serious cache bug
Let me check this thoroughly. Until then, I strictly advise users NOT TO USE this suggestion.

We'll keep everyone updated.  ;)

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

  • Maxim Milakov
  • Maxim Milakov's Avatar Topic Author
  • Offline
  • New Member
More
17 years 1 week ago #2277 by Maxim Milakov
Replied by Maxim Milakov on topic Re: Cache bug?
I also advise users not to use my suggestion  ;) I published the code to help you locate and fix the issue.

Please Log in or Create an account to join the conversation.

More
17 years 1 week ago - 17 years 1 week ago #2278 by JoomlaWorks
Replied by JoomlaWorks on topic Re: Cache bug?
OK, seems you're right at the moment. We're doing some more tests and then we will issue an update.

EDIT: We had forgotten 2 dots. You were right. Therefore, I have decided to send George to the firing squad where he will be feather-tortured on site before being executed naked in front of his ex girlfriends. Anyone wishing to contribute to his orphan family is kindly accepted...  :D

People, there's no need to worry for now. v1.3 will be sent to everyone by Friday including some additional fixes.  ;)

Fotis / JoomlaWorks Support Team
---
Please search the forum before posting a new topic :)

Please Log in or Create an account to join the conversation.

More
17 years 3 days ago #2279 by Thomas Leuxner
Replied by Thomas Leuxner on topic Re: Cache bug?

People, there's no need to worry for now. v1.3 will be sent to everyone by Friday including some additional fixes.  ;)

Any news on 1.3 resolving the cache bug?

This week I functioned as an incubator of innovations for contributions to the value chain. To the observer it looks as if I am doing nothing, but on the inside, I am incubating my brains out...

Please Log in or Create an account to join the conversation.


Powered by Kunena Forum