Keyword

Feed error - Failed loading XML... (with a fix)

More
3 years 3 months ago - 3 years 3 months ago #154190 by Steve
Steve created the topic: Feed error - Failed loading XML... (with a fix)
Failed loading XML... error parsing attribute name attributes construct error Couldn't find end of Start Tag line 1 Extra content at the end of the document


I had 2 feeds that have stopped loading since updating to version 3.5.

I found that this was causing the error
<rss version="2.0"xmlns:atom="http://www.w3.org/2005/Atom">

So I modified the helper file to replace the block of text.

about line 268
// cleanup the content received
			$repurl= array('<rss version="2.0"xmlns:atom="http://www.w3.org/2005/Atom">');
			$goodurl= array('<rss version="2.0"xmlns:atom="http://www.w3.org/2005/Atom">' =>'<rss version="2.0">');

			$fgcOutput = preg_replace("#(\n|\r|\s\s+|<!--(.*?)-->)#s", "", $fgcOutput);
			$fgcOutput = preg_replace("#(\t)#s", " ", $fgcOutput);

			$fgcOutput = str_replace($repurl, $goodurl, $fgcOutput);

I am not sure this is the best way to fix it but it did solve the problem and wanted t let anyone else with the problem know.

SC
Last edit: 3 years 3 months ago by Steve.

Please Log in or Create an account to join the conversation.

More
3 years 3 months ago #154499 by Krikor Boghossian
Krikor Boghossian replied the topic: Feed error - Failed loading XML... (with a fix)
Thank you Steve for the fix.
You can also make a PR in Github so we can evaluate it for a future release. github.com/joomlaworks/simple-rss-feed-reader

IMPORTANT: Please search the forum before posting a question!

JoomlaWorks Support Team Member

---
JoomlaWorks
www.joomlaworks.net/

Please Log in or Create an account to join the conversation.

More
3 years 3 months ago #154656 by Steve
Steve replied the topic: Feed error - Failed loading XML... (with a fix)
Hello Krikor
I have submitted it to GitHub.

Steve

Please Log in or Create an account to join the conversation.

More
3 years 3 months ago #154696 by Krikor Boghossian
Krikor Boghossian replied the topic: Feed error - Failed loading XML... (with a fix)
Thank you Steve,
Feedback is invaluable for us :)

IMPORTANT: Please search the forum before posting a question!

JoomlaWorks Support Team Member

---
JoomlaWorks
www.joomlaworks.net/

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #154813 by Bryan Teague
Bryan Teague replied the topic: Feed error - Failed loading XML... (with a fix)
Unfortunately I am not a programmer, but was able to make the changes suggested but they did not work for me. I assume that is because the feed coming from the site does not match the strings being looked for after I updated the site to Joomla 3.5.1 from 2.5.28. The feed is coming out of RS Blog svnereida.com/blog?format=feed&type=rss the site is svnereida.com/ any suggestions would be really appreciated. The odd part of this is that sometimes the feed will display under the Recent Logs on the home page and sometimes it will not.

Thank you,
Mike
Last edit: 3 years 2 months ago by Bryan Teague. Reason: added the odd part of this

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago - 3 years 2 months ago #154818 by Steve
Steve replied the topic: Feed error - Failed loading XML... (with a fix)
It loads fine for me can you post a copy of your complete helper file I will take a look at it.

( cut and paste it here and wrap it in the <> code tags from a bove is the easiest way )

Steve
Last edit: 3 years 2 months ago by Steve.

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #154823 by Bryan Teague
Bryan Teague replied the topic: Feed error - Failed loading XML... (with a fix)
Steve,

The helper.php file is below. One of the problems is that this does not happen consistently, I just checked and we are getting the Failed loading XML... Extra content at the end of the document again. Which makes this more confusions as it should either work or fail all the times with what the issue is.

Thank you,
Mike

<?php
/**
 * @version    3.5
 * @package    Simple RSS Feed Reader (module)
 * @author     JoomlaWorks - https://www.joomlaworks.net
 * @copyright  Copyright (c) 2006 - 2016 JoomlaWorks Ltd. All rights reserved.
 * @license    GNU/GPL license: http://www.gnu.org/copyleft/gpl.html
 */

// no direct access
defined('_JEXEC') or die('Restricted access');

class SimpleRssFeedReaderHelper {

	function getFeeds($feedsArray,$totalFeedItems,$perFeedItems,$feedTimeout,$dateFormat,$wordLimit,$cacheLocation,$cacheTime,$imageHandling,$riWidth, $feedItemLinkRedirect){

		/*
			Legend for '$imageHandling':
			0 - no images
			1 - fetch first image only and hide others
			2 - fetch and resize first image only and hide others
		*/

		// API
		$mainframe = JFactory::getApplication();

		// Check if the cache folder exists
		$cacheFolderPath = JPATH_SITE.DS.$cacheLocation;
		if(file_exists($cacheFolderPath) && is_dir($cacheFolderPath)){
			// all OK
		} else {
			mkdir($cacheFolderPath);
		}

		$feeds = self::multiRequest($feedsArray,$cacheTime);
		$parsedFeeds = self::parseFeeds($feeds);
		$feedItemsArray = array();

		foreach($parsedFeeds as $feed){
			foreach($feed->feedItems as $key=>$item){
				if($key < $perFeedItems){
					// Create an object to store feed elements
					$feedElements[$key] = new JObject;

					$feedElements[$key]->itemTitle 			= $item->title;
					$feedElements[$key]->itemLink 			= $item->link;
					$feedElements[$key]->itemDate 			= strftime($dateFormat,strtotime($item->pubDate));
					$feedElements[$key]->itemDateRSS 		= $item->pubDate;
					$feedElements[$key]->itemDescription 	= $item->description;
					$feedElements[$key]->feedImageSrc		= '';

					$feedElements[$key]->feedTitle 			= self::wordLimiter($feed->feedTitle,10);
					$feedElements[$key]->feedURL			= $feed->feedSubscribeUrl;
					$feedElements[$key]->siteURL			= $feed->feedLink;

					// Give each feed an index based on date
					$itemDateIndex = strftime('%Y%m%d%H%M',strtotime($item->pubDate)).'_'.$key;

					// Pass all feed objects to an array
					$feedItemsArray[$itemDateIndex] = $feedElements[$key];
				}
			}
		}

		// Reverse sort by key (=feed date)
		krsort($feedItemsArray);

		// Limit output
		$outputArray = array();
		$counter = 0;
		foreach($feedItemsArray as $feedItem){
			if($counter>=$totalFeedItems) continue;

			// Clean up the feed title
			$feedItem->itemTitle = trim(htmlentities($feedItem->itemTitle, ENT_QUOTES, 'utf-8'));

			// URL Redirect
			if(isset($feedItemLinkRedirect) && $feedItemLinkRedirect){
				$feedItem->itemLink = JURI::root(true).'/modules/mod_jw_srfr/redir.php?url='.urlencode($feedItem->itemLink);
			}

			// Determine if an image reference exists in the feed description
			if($imageHandling==1 || $imageHandling==2){
				$feedImage = self::getFirstImage($feedItem->itemDescription);

				// If it does, copy, resize and store it locally
				if(isset($feedImage) && $feedImage['ext']){

					// first remove the img tag from the description
					$feedItem->itemDescription = str_replace($feedImage['tag'],'',trim($feedItem->itemDescription));

					// then resize and/or assign to variable
					if($imageHandling==2){
						$feedItem->feedImageSrc = 'http://ir0.mobify.com/'.$riWidth.'/'.$feedImage['src'];
					} else {
						$feedItem->feedImageSrc = $feedImage['src'];
					}
				} else {
					$feedItem->feedImageSrc = '';
				}
			}

			// Strip out images from the description
			$feedItem->itemDescription = preg_replace("#<img.+?>#s","",$feedItem->itemDescription);

			// Word limit
			if($wordLimit){
				$feedItem->itemDescription = self::wordLimiter($feedItem->itemDescription,$wordLimit);
			}

			$outputArray[] = $feedItem;
			$counter++;
		}

		return $outputArray;
	}

	// Get array of feeds
	function multiRequest($data,$cacheTime) {
		ini_set('max_execution_time',120); // Set max_execution_time to 120
		$result = array();
		foreach ($data as $id => $url) {
			$url = trim($url);
			if($url) {
				$feed = self::getFile($url,$cacheTime,$subFolderName='feeds');
				$result[$id] = JFile::read($feed);
			}
		}
		return $result;
	}

	// Parse array of feeds
	function parseFeeds($feeds){
		$feedContents = array();
		foreach($feeds as $key=>$feed){
			libxml_use_internal_errors(true);
			$xml = simplexml_load_string($feed);

			// If the feed didn't parse, display a warning and skip it
			if ($xml === false) {
				$msg = "Failed loading XML...\n";
				foreach(libxml_get_errors() as $error) {
					$msg .= "\n" . $error->message;
				}
				JFactory::getApplication()->enqueueMessage($msg);
				libxml_clear_errors();
				continue;
			}

			$feedContents[$key] = new stdClass;

			if(is_object($xml) && $items = $xml->xpath("/rss/channel/item")) {
				$feedContents[$key]->feedSubscribeUrl = $feed;
				$feedContents[$key]->feedTitle = $xml->channel->title;
				$feedContents[$key]->feedLink = $xml->channel->link;
				$feedContents[$key]->feedPubDate = $xml->channel->pubDate;
				$feedContents[$key]->feedDescription = $xml->channel->description;
				foreach($items as $item){
					$feedContents[$key]->feedItems[] = $item;
				}
			} elseif(is_object($xml) && $items = $xml->xpath("/*[local-name()='feed' and namespace-uri()='http://www.w3.org/2005/Atom'] /*[local-name()='entry' and namespace-uri()='http://www.w3.org/2005/Atom']")) {
				$feedContents[$key]->feedSubscribeUrl = $feed;
				$feedContents[$key]->feedTitle = (string)$xml->title;
				$feedContents[$key]->feedLink = (string)$xml->link->attributes()->href;
				$feedContents[$key]->feedPubDate = (string)$xml->updated;
				$feedContents[$key]->feedDescription = (string)$xml->subtitle;
				foreach ($items as $item) {
					$tmp = new stdClass();
					$tmp->title = (string)$item->title;
					if($item->link->count() > 1){
						foreach($item->link as $link){
							if((string)$link->attributes()->rel == 'alternate') {
								$tmp->link = (string)$link->attributes()->href;
							}
						}
					} else {
						$tmp->link = (string)$item->link->attributes()->href;
					}
					$tmp->pubDate = (string)$item->updated;
					$tmp->description = (!empty($item->content)) ? $item->content:$item->summary;
					$tmp->author = (string)$item->author->name;
					$feedContents[$key]->feedItems[] = $tmp;
				}
			}
		}
		return $feedContents;
	}

	// Word Limiter
	function wordLimiter($str,$limit=100,$end_char='[&#8230;]'){
		if (trim($str) == '') return $str;
		$str = strip_tags($str);
		preg_match('/\s*(?:\S*\s*){'. (int) $limit .'}/', $str, $matches);
		if (strlen($matches[0]) == strlen($str)) $end_char = '';
		return rtrim($matches[0]).$end_char;
	}

	// Grab the first image in a string
	function getFirstImage($string){
		// find images
		$regex = "#<img.+?>#s";
		if (preg_match_all($regex, $string, $matches, PREG_PATTERN_ORDER) > 0){
			$img = array();
			// Entire <img> tag
			$img['tag'] = $matches[0][0];
			// Image src
			if(preg_match("#src=\".+?\"#s",$img['tag'],$imgSrc)){
				$img['src'] = str_replace('src="','',$imgSrc[0]);
				$img['src'] = str_replace('"','',$img['src']);
			} else {
				$img['src'] = false;
			}
			// Is this a real content image?
			if(preg_match("#\.(jpg|jpeg|png|gif|bmp)#s",strtolower($img['src']),$imgExt)){
				$img['ext'] = true;
			} else {
				$img['ext'] = false;
			}
			return $img;
		}
	}

	// Get remote file
	function getFile($url, $cacheTime=3600, $subFolderName='', $extensionName='mod_jw_srfr'){

		jimport('joomla.filesystem.file');

		// Check cache folder
		if($subFolderName){
			$cacheFolderPath = JPATH_SITE.DS.'cache'.DS.$extensionName.DS.$subFolderName;
		} else {
			$cacheFolderPath = JPATH_SITE.DS.'cache'.DS.$extensionName;
		}

		if(file_exists($cacheFolderPath) && is_dir($cacheFolderPath)){
			// all OK
		} else {
			mkdir($cacheFolderPath);
		}

		$url = trim($url);

		if(substr($url,0,4)=="http"){
			$turl = explode("?", $url);
			$matchComponents = array("#(http|https)\:\/\/#s","#www\.#s");
			$replaceComponents = array("","");
			$turl = preg_replace($matchComponents,$replaceComponents,$turl[0]);
			$turl = str_replace(array("/","-","."),array("_","_","_"),$turl);
			$tmpFile = $cacheFolderPath.DS.urlencode($turl).'_'.md5($url).'.cache';
		} else {
			$tmpFile = $cacheFolderPath.DS.'cached_'.md5($url);
		}

		// Check if a cached copy exists otherwise create it
		if(file_exists($tmpFile) && is_readable($tmpFile) && (filemtime($tmpFile)+$cacheTime) > time()){

			$result = $tmpFile;

		} else {
			// Get file
			if(substr($url,0,4)=="http"){
				// remote file
				if(ini_get('allow_url_fopen')){
					// file_get_contents
					$fgcOutput = JFile::read($url);

					// cleanup the content received
                        $repurl= array('<rss version="2.0"xmlns:atom="http://www.w3.org/2005/Atom">');
			$goodurl= array('<rss version="2.0"xmlns:atom="http://www.w3.org/2005/Atom">' =>'<rss version="2.0">');

			$fgcOutput = preg_replace("#(\n|\r|\s\s+|<!--(.*?)-->)#s", "", $fgcOutput);
			$fgcOutput = preg_replace("#(\t)#s", " ", $fgcOutput);

			$fgcOutput = str_replace($repurl, $goodurl, $fgcOutput);
					
					
					

					JFile::write($tmpFile,$fgcOutput);
				} elseif(in_array('curl',get_loaded_extensions())) {
					// cURL
					$ch = curl_init();
					curl_setopt($ch, CURLOPT_URL, $url);
					curl_setopt($ch, CURLOPT_HEADER, false);
					curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5);
					curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
					$chOutput = curl_exec($ch);
					curl_close($ch);
					JFile::write($tmpFile,$chOutput);
				} else {
					// fsockopen
					$readURL = parse_url($url);
					$relativePath = (isset($readURL['query'])) ? $readURL['path']."?".$readURL['query'] : $readURL['path'];
					$fp = fsockopen($readURL['host'], 80, $errno, $errstr, 5);
					if (!$fp) {
						JFile::write($tmpFile,'');
					} else {
						$out = "GET ".$relativePath." HTTP/1.1\r\n";
						$out .= "Host: ".$readURL['host']."\r\n";
						$out .= "Connection: Close\r\n\r\n";
						fwrite($fp, $out);
						$header = '';
						$body = '';
						do { $header .= fgets($fp,128); } while (strpos($header,"\r\n\r\n")=== false); // get the header data
						while (!feof($fp)) $body .= fgets($fp,128); // get the actual content
						fclose($fp);
						JFile::write($tmpFile,$body);
					}
				}

				$result = $tmpFile;

			} else {

				// local file
				$result = $url;

			}

		}

		return $result;
	}

} // END CLASS

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #154826 by Steve
Steve replied the topic: Feed error - Failed loading XML... (with a fix)
The helper file looks good. I was able to see it fail and this is the extra content in your file
<br />
<b>Notice</b>:  Unknown: Mailbox is empty (errflg=1) in <b>Unknown</b> on line <b>0</b><br />

I did a quick google search and it appears to be an error with imap mailboxes.

I would double check your RSBlog config and see if there is any thing on there site that references the error. If that doesnt work you could always you this same idea for removing that line of code.
changing these lines like below
$repurl= array('</rss><br /><b>Notice</b>:  Unknown: Mailbox is empty (errflg=1) in <b>Unknown</b> on line <b>0</b><br />'); 
$goodurl= array('</rss><br /><b>Notice</b>:  Unknown: Mailbox is empty (errflg=1) in <b>Unknown</b> on line <b>0</b><br />' =>'</rss>');
Steve

Please Log in or Create an account to join the conversation.

More
3 years 2 months ago #154904 by Bryan Teague
Bryan Teague replied the topic: Feed error - Failed loading XML... (with a fix)
Steve,

Thank you very much, I will check that.

Mike

Please Log in or Create an account to join the conversation.


Powered by Kunena Forum